Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: abstract types to shared package #1593

Merged
merged 11 commits into from
Dec 6, 2024
Merged

chore: abstract types to shared package #1593

merged 11 commits into from
Dec 6, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 1, 2024

Abstracted all the shared types from the rrweb-snapshot project into the shared @rrweb/types package as was done in #1475

Additional context in https://rrweb.slack.com/archives/C0614SW58TW/p1730134366873209

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8508bed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@rrweb/all Major
rrdom-nodejs Major
rrdom Major
rrweb-snapshot Major
rrweb Major
@rrweb/rrweb-plugin-canvas-webrtc-record Major
rrweb-player Major
@rrweb/replay Major
@rrweb/record Major
@rrweb/types Major
@rrweb/packer Major
@rrweb/utils Major
@rrweb/web-extension Major
rrvideo Major
@rrweb/rrweb-plugin-console-record Major
@rrweb/rrweb-plugin-console-replay Major
@rrweb/rrweb-plugin-sequential-id-record Major
@rrweb/rrweb-plugin-sequential-id-replay Major
@rrweb/rrweb-plugin-canvas-webrtc-replay Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@daibhin daibhin mentioned this pull request Nov 4, 2024
Merged
3 tasks
@Juice10 Juice10 self-requested a review November 8, 2024 08:30
@Juice10 Juice10 self-assigned this Nov 8, 2024
@pauldambra pauldambra mentioned this pull request Nov 20, 2024
Open
@eoghanmurray
Copy link
Contributor

Thanks for doing this thankless work!
I was able to rebase #1475 on top of this, so all good as far as I'm concerned.
@daibhin could you add a changeset as I'm unable to commit directly to this branch?

@daibhin
Copy link
Contributor Author

daibhin commented Nov 30, 2024

@eoghanmurray just went to do it there but looks like you got there ahead of me :)

@eoghanmurray
Copy link
Contributor

Not sure why the bot isn't picking up that there's a changeset; it seemed to have failed when I added it with the changeset-bot

Juice10
Juice10 requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Juice10 Juice10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this work @daibhin! This will make landing the asset PRs that @eoghanmurray and I have been working on a lot less painful

.changeset/soft-worms-tan.md Outdated Show resolved Hide resolved
packages/types/src/index.ts Show resolved Hide resolved
packages/types/src/index.ts Show resolved Hide resolved
@daibhin daibhin requested a review from Juice10 December 6, 2024 10:12
@Juice10 Juice10 merged commit 5a78938 into rrweb-io:master Dec 6, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Merged
@daibhin daibhin deleted the dn-chore/type-changes branch December 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juice10 Juice10 Juice10 approved these changes

Assignees

@Juice10 Juice10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daibhin @eoghanmurray @Juice10